Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/debug.cc

Issue 10698103: Larger stack trace string in the minidump when catching Debug::Break crash. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1009 matching lines...) Expand 10 before | Expand all | Expand 10 after
1020 PutValuesOnStackAndDie(0xBEEEEEEE, 1020 PutValuesOnStackAndDie(0xBEEEEEEE,
1021 frame->fp(), 1021 frame->fp(),
1022 thread_local_.last_fp_, 1022 thread_local_.last_fp_,
1023 reinterpret_cast<Address>(0xDEADDEAD), 1023 reinterpret_cast<Address>(0xDEADDEAD),
1024 count, 1024 count,
1025 NULL, 1025 NULL,
1026 0xCEEEEEEE); 1026 0xCEEEEEEE);
1027 } else if (it.frame()->fp() != thread_local_.last_fp_) { 1027 } else if (it.frame()->fp() != thread_local_.last_fp_) {
1028 // We crawled over last_fp_, without getting a match. 1028 // We crawled over last_fp_, without getting a match.
1029 Handle<String> stack = isolate_->StackTraceString(); 1029 Handle<String> stack = isolate_->StackTraceString();
1030 char buffer[2048]; 1030 char buffer[8192];
1031 String::WriteToFlat(*stack, buffer, 0, 2047); 1031 String::WriteToFlat(*stack, buffer, 0, 8191);
1032 PutValuesOnStackAndDie(0xDEEEEEEE, 1032 PutValuesOnStackAndDie(0xDEEEEEEE,
1033 frame->fp(), 1033 frame->fp(),
1034 thread_local_.last_fp_, 1034 thread_local_.last_fp_,
1035 it.frame()->fp(), 1035 it.frame()->fp(),
1036 count, 1036 count,
1037 buffer, 1037 buffer,
1038 0xFEEEEEEE); 1038 0xFEEEEEEE);
1039 } 1039 }
1040 1040
1041 // If we found original frame 1041 // If we found original frame
(...skipping 2662 matching lines...) Expand 10 before | Expand all | Expand 10 after
3704 { 3704 {
3705 Locker locker; 3705 Locker locker;
3706 Isolate::Current()->debugger()->CallMessageDispatchHandler(); 3706 Isolate::Current()->debugger()->CallMessageDispatchHandler();
3707 } 3707 }
3708 } 3708 }
3709 } 3709 }
3710 3710
3711 #endif // ENABLE_DEBUGGER_SUPPORT 3711 #endif // ENABLE_DEBUGGER_SUPPORT
3712 3712
3713 } } // namespace v8::internal 3713 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698