Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10698053: Breaks compile on Linux Aura (Closed)

Created:
8 years, 5 months ago by Albert Bodenhamer
Modified:
8 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, rdsmith+dwatch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Breaks compile on Linux Aura Revert 144938 - Start consolidating cross-port file selection code into ui/base/dialogs. Part 2: Split the chrome specific policy code into a chrome class that implements a general interface. In the next patch, we'll actually move SelectFileDialog to ui/base/dialogs/. BUG=134529 TEST=none Review URL: https://chromiumcodereview.appspot.com/10667026 TBR=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -431 lines) Patch
MM chrome/browser/bookmarks/bookmark_extension_api.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_file_helper.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/download/download_file_picker.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/save_package_file_picker_chromeos.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/certificate_dialogs.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/certificate_dialogs.cc View 6 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/ui/chrome_select_file_policy.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/chrome_select_file_policy.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/chrome_select_file_policy_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M chrome/browser/ui/cocoa/select_file_dialog_mac.mm View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl_gtk.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/select_file_dialog.h View 5 chunks +7 lines, -17 lines 0 comments Download
M chrome/browser/ui/select_file_dialog.cc View 3 chunks +30 lines, -9 lines 0 comments Download
A + chrome/browser/ui/select_file_dialog_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.h View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_win.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog_view.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler2.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
MM ui/base/dialogs/base_shell_dialog.h View 2 chunks +3 lines, -3 lines 0 comments Download
D ui/base/dialogs/select_file_policy.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/base/dialogs/select_file_policy.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Albert Bodenhamer
8 years, 5 months ago (2012-06-29 19:00:30 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698