Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 10698009: Make profile history easily filterable. (Closed)

Created:
8 years, 5 months ago by Elliot Glaysher
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make history easily filterable. We're renaming the two profile directories that we want to keep, and dropping GTK specific tests in anticipation of the changeover later this year. Every change to the history, theme or profile format required a new giant binary file added to our repository. There are tens of versions of the history database alone, each weighing at over 10 megabytes. In the proposed pruned git repository, these are the largest files. This standardizes both remaining test profile directories on the same set of binaries (they're currently out of sync), and moves them to new path names so we can purge the previous paths from history. BUG=111570 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153933

Patch Set 1 #

Patch Set 2 : Rebuild the patch with the new history database files. #

Patch Set 3 : Rebase to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-39 lines, -192 lines) Patch
D chrome/test/data/profiles/complex_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUY_c8CDA View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYj9gCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYjNgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYnMgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYw8gCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYwsgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json View 1 chunk +0 lines, -35 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/Current Version View 1 chunk +0 lines, -1 line 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/PreferencesTemplate View 1 chunk +0 lines, -69 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/complex_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame/Default/Preferences View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/profiles/custom_frame/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/custom_frame_gtk_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Preferences View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/custom_frame_gtk_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/gtk_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/Preferences View 1 chunk +0 lines, -16 lines 0 comments Download
chrome/test/data/profiles/gtk_theme/Default/Thumbnails View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/gtk_theme/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Cookies View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached Theme.pak View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUY_c8CDA View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYj9gCDA View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYjNgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYnMgCDA View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYw8gCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/i/agxjaHJvbWV0aGVtZXNyDAsSBEZpbGUYwsgCDA View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/Current Version View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Full Text Index View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/History View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/PreferencesTemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_complex_theme/Default/Visited Links View Binary file 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Favicons View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Preferences View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/profile_with_default_theme/Default/Top Sites View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/profiles/profile_with_default_theme/Default/Visited Links View Binary file 0 comments Download
A + chrome/test/data/profiles/profile_with_default_theme/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Cookies View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Favicons View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/typical_history/Default/Full Text Index View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Preferences View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/profiles/typical_history/Default/Top Sites View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/typical_history/Default/Visited Links View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/test/data/profiles/typical_history/README.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/perf/feature_startup_test.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
chrome/test/ui/ui_test.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
8 years, 5 months ago (2012-06-27 18:10:23 UTC) #1
Elliot Glaysher
+chase
8 years, 5 months ago (2012-06-27 19:08:23 UTC) #2
szager1
I'm not familiar enough with this code to review it with confidence, and I believe ...
8 years, 5 months ago (2012-06-28 21:26:23 UTC) #3
cmp
erg: how do you want to proceed? do you require phajdan, or is it still ...
8 years, 5 months ago (2012-06-28 21:45:01 UTC) #4
Elliot Glaysher
On 2012/06/28 21:45:01, cmp wrote: > erg: how do you want to proceed? do you ...
8 years, 5 months ago (2012-06-28 22:05:35 UTC) #5
cmp
lgtm Are any of themes used or capable of being used by platforms besides Linux? ...
8 years, 5 months ago (2012-07-09 23:00:16 UTC) #6
Paweł Hajdan Jr.
LGTM (sorry for delay, returning from vacation)
8 years, 3 months ago (2012-08-29 14:27:51 UTC) #7
Elliot Glaysher
8 years, 3 months ago (2012-08-29 17:10:26 UTC) #8
On 2012/08/29 14:27:51, Paweł Hajdan Jr. wrote:
> LGTM (sorry for delay, returning from vacation)

I've lost the patch in a computer upgrade (and the patch is out of date since
there have been *more* changes to the history database). Now that I have Pawel's
lgtm, I'll recreate the patch and add it to this patch set.

Powered by Google App Engine
This is Rietveld 408576698