Issue 10697075: Do not suffix ChromeHTML\Application\ApplicationName in the Windows registry -- it's a user visible…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10697075: Do not suffix ChromeHTML\Application\ApplicationName in the Windows registry -- it's a user visible… (Closed)

Created:
8 years, 5 months ago by gab

Modified:
8 years, 5 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org, chrome-win8-eng_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not suffix ChromeHTML\Application\ApplicationName in the Windows registry -- it's a user visible string BUG=135668 TEST=No suffix is displayed when selecting defaults on Windows for user-level installs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145460

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/installer/util/shell_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gab

I tested by hand that modifying this registry value affected the visible string in Default ...

8 years, 5 months ago (2012-07-03 22:52:55 UTC) #1

gab

On 2012/07/04 01:44:18, grt wrote: > lgtm It fixes the Default Programs dialog. I wasn't ...

8 years, 5 months ago (2012-07-04 14:03:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10697075/1

8 years, 5 months ago (2012-07-04 14:03:25 UTC) #4

Change committed as 145460

Expand Messages | Collapse Messages