Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: chrome/installer/util/shell_util.cc

Issue 10697075: Do not suffix ChromeHTML\Application\ApplicationName in the Windows registry -- it's a user visible… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines functions that integrate Chrome in Windows shell. These 5 // This file defines functions that integrate Chrome in Windows shell. These
6 // functions can be used by Chrome as well as Chrome installer. All of the 6 // functions can be used by Chrome as well as Chrome installer. All of the
7 // work is done by the local functions defined in anonymous namespace in 7 // work is done by the local functions defined in anonymous namespace in
8 // this class. 8 // this class.
9 9
10 #include "chrome/installer/util/shell_util.h" 10 #include "chrome/installer/util/shell_util.h"
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 string16 chrome_application(chrome_html_prog_id + 207 string16 chrome_application(chrome_html_prog_id +
208 ShellUtil::kRegApplication); 208 ShellUtil::kRegApplication);
209 entries->push_front(new RegistryEntry( 209 entries->push_front(new RegistryEntry(
210 chrome_application, ShellUtil::kRegAppUserModelId, app_id)); 210 chrome_application, ShellUtil::kRegAppUserModelId, app_id));
211 entries->push_front(new RegistryEntry( 211 entries->push_front(new RegistryEntry(
212 chrome_application, ShellUtil::kRegApplicationIcon, icon_path)); 212 chrome_application, ShellUtil::kRegApplicationIcon, icon_path));
213 // TODO(grt): http://crbug.com/75152 Write a reference to a localized 213 // TODO(grt): http://crbug.com/75152 Write a reference to a localized
214 // resource for name, description, and company. 214 // resource for name, description, and company.
215 entries->push_front(new RegistryEntry( 215 entries->push_front(new RegistryEntry(
216 chrome_application, ShellUtil::kRegApplicationName, 216 chrome_application, ShellUtil::kRegApplicationName,
217 dist->GetAppShortCutName().append(suffix))); 217 dist->GetAppShortCutName()));
218 entries->push_front(new RegistryEntry( 218 entries->push_front(new RegistryEntry(
219 chrome_application, ShellUtil::kRegApplicationDescription, 219 chrome_application, ShellUtil::kRegApplicationDescription,
220 dist->GetAppDescription())); 220 dist->GetAppDescription()));
221 entries->push_front(new RegistryEntry( 221 entries->push_front(new RegistryEntry(
222 chrome_application, ShellUtil::kRegApplicationCompany, 222 chrome_application, ShellUtil::kRegApplicationCompany,
223 dist->GetPublisherName())); 223 dist->GetPublisherName()));
224 } 224 }
225 225
226 return true; 226 return true;
227 } 227 }
(...skipping 1286 matching lines...) Expand 10 before | Expand all | Expand 10 after
1514 chrome_exe.c_str(), 1514 chrome_exe.c_str(),
1515 shortcut.c_str(), 1515 shortcut.c_str(),
1516 chrome_path.value().c_str(), 1516 chrome_path.value().c_str(),
1517 arguments.c_str(), 1517 arguments.c_str(),
1518 description.c_str(), 1518 description.c_str(),
1519 icon_path.c_str(), 1519 icon_path.c_str(),
1520 icon_index, 1520 icon_index,
1521 app_id.c_str(), 1521 app_id.c_str(),
1522 ConvertShellUtilShortcutOptionsToFileUtil(options)); 1522 ConvertShellUtilShortcutOptionsToFileUtil(options));
1523 } 1523 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698