Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10697056: Extensions Docs Server: Handlebar updates (Closed)

Created:
8 years, 5 months ago by cduvall
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, chebert, clintstaley
Visibility:
Public.

Description

Extensions Docs Server: Handlebar updates Updated the version of Handlebar in third_party, and made some minor tweaks. BUG=131095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145214

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
cduvall
New version of Handlebar, thanks! All tests pass, and the pages render correctly.
8 years, 5 months ago (2012-07-02 17:48:24 UTC) #1
not at google - send to devlin
lgtm, I remember there being some places where we added \n in things, but I ...
8 years, 5 months ago (2012-07-02 23:11:03 UTC) #2
cduvall
8 years, 5 months ago (2012-07-02 23:12:12 UTC) #3
On 2012/07/02 23:11:03, kalman wrote:
> lgtm, I remember there being some places where we added \n in things, but I
> don't remember if they're checked in. I guess if they're still in code review
I
> can comment on them.
> 
> Thanks for doing this.

Yeah, those are still in review. And np :)

Powered by Google App Engine
This is Rietveld 408576698