src/ia32/assembler-ia32.cc - Issue 10697004: Enable the CHECK for near-jump displacement range in Release mode too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32.cc

Issue 10697004: Enable the CHECK for near-jump displacement range in Release mode too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/assembler-ia32.cc

diff --git a/src/ia32/assembler-ia32.cc b/src/ia32/assembler-ia32.cc

index a42f6324e34abe4058d7ab9cc24a3faafb4f0f77..1dcf26c532fafbdc02d00d0c5c1dd7f6dde1d24e 100644

--- a/src/ia32/assembler-ia32.cc

+++ b/src/ia32/assembler-ia32.cc

@@ -1373,7 +1373,7 @@ void Assembler::bind_to(Label* L, int pos) {

ASSERT(offset_to_next <= 0);

// Relative address, relative to point after address.

int disp = pos - fixup_pos - sizeof(int8_t);

- ASSERT(0 <= disp && disp <= 127);

+ CHECK(0 <= disp && disp <= 127);

set_byte_at(fixup_pos, disp);

if (offset_to_next < 0) {

L->link_to(fixup_pos + offset_to_next, Label::kNear);

« no previous file with comments | « no previous file | src/x64/assembler-x64.cc » ('j') | no next file with comments »