Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 10697004: Enable the CHECK for near-jump displacement range in Release mode too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 1355 matching lines...) Expand 10 before | Expand all | Expand 10 after
1366 } 1366 }
1367 disp.next(L); 1367 disp.next(L);
1368 } 1368 }
1369 while (L->is_near_linked()) { 1369 while (L->is_near_linked()) {
1370 int fixup_pos = L->near_link_pos(); 1370 int fixup_pos = L->near_link_pos();
1371 int offset_to_next = 1371 int offset_to_next =
1372 static_cast<int>(*reinterpret_cast<int8_t*>(addr_at(fixup_pos))); 1372 static_cast<int>(*reinterpret_cast<int8_t*>(addr_at(fixup_pos)));
1373 ASSERT(offset_to_next <= 0); 1373 ASSERT(offset_to_next <= 0);
1374 // Relative address, relative to point after address. 1374 // Relative address, relative to point after address.
1375 int disp = pos - fixup_pos - sizeof(int8_t); 1375 int disp = pos - fixup_pos - sizeof(int8_t);
1376 ASSERT(0 <= disp && disp <= 127); 1376 CHECK(0 <= disp && disp <= 127);
1377 set_byte_at(fixup_pos, disp); 1377 set_byte_at(fixup_pos, disp);
1378 if (offset_to_next < 0) { 1378 if (offset_to_next < 0) {
1379 L->link_to(fixup_pos + offset_to_next, Label::kNear); 1379 L->link_to(fixup_pos + offset_to_next, Label::kNear);
1380 } else { 1380 } else {
1381 L->UnuseNear(); 1381 L->UnuseNear();
1382 } 1382 }
1383 } 1383 }
1384 L->bind_to(pos); 1384 L->bind_to(pos);
1385 } 1385 }
1386 1386
(...skipping 1230 matching lines...) Expand 10 before | Expand all | Expand 10 after
2617 fprintf(coverage_log, "%s\n", file_line); 2617 fprintf(coverage_log, "%s\n", file_line);
2618 fflush(coverage_log); 2618 fflush(coverage_log);
2619 } 2619 }
2620 } 2620 }
2621 2621
2622 #endif 2622 #endif
2623 2623
2624 } } // namespace v8::internal 2624 } } // namespace v8::internal
2625 2625
2626 #endif // V8_TARGET_ARCH_IA32 2626 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/x64/assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698