Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5822)

Unified Diff: chrome/browser/platform_util_chromeos.cc

Issue 10696222: Make chrome::Navigate take in a Browser* that is never NULL. That function doesn't have a context, … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/ui/browser_navigator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/platform_util_chromeos.cc
===================================================================
--- chrome/browser/platform_util_chromeos.cc (revision 146674)
+++ chrome/browser/platform_util_chromeos.cc (working copy)
@@ -10,6 +10,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/chromeos/extensions/file_manager_util.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "content/public/browser/browser_thread.h"
@@ -36,9 +37,11 @@
void OpenURL(const std::string& url) {
// TODO(beng): improve this to locate context from call stack.
- chrome::NavigateParams params(NULL, GURL(url), content::PAGE_TRANSITION_LINK);
+ Browser* browser = browser::FindOrCreateTabbedBrowser(
+ ProfileManager::GetDefaultProfileOrOffTheRecord());
+ chrome::NavigateParams params(
+ browser, GURL(url), content::PAGE_TRANSITION_LINK);
params.disposition = NEW_FOREGROUND_TAB;
- params.profile = ProfileManager::GetDefaultProfileOrOffTheRecord();
chrome::Navigate(&params);
}
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/ui/browser_navigator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698