Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: chrome/browser/ui/browser_navigator.h

Issue 10696222: Make chrome::Navigate take in a Browser* that is never NULL. That function doesn't have a context, … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/platform_util_chromeos.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_navigator.h
===================================================================
--- chrome/browser/ui/browser_navigator.h (revision 146674)
+++ chrome/browser/ui/browser_navigator.h (working copy)
@@ -15,7 +15,6 @@
#include "webkit/glue/window_open_disposition.h"
class Browser;
-class Profile;
class TabContents;
namespace chrome {
@@ -167,8 +166,7 @@
// [in] Specifies a Browser object where the navigation could occur or the
// tab could be added. Navigate() is not obliged to use this Browser if
- // it is not compatible with the operation being performed. If NULL,
- // |profile| should be specified to find or create a matching Browser.
+ // it is not compatible with the operation being performed.
// [out] Specifies the Browser object where the navigation occurred or the
// tab was added. Guaranteed non-NULL unless the disposition did not
// require a navigation, in which case this is set to NULL
@@ -179,10 +177,6 @@
// objects are deleted when the user closes a visible browser window).
Browser* browser;
- // If |browser| == NULL, specifies a Profile to use when finding or
- // creating a Browser.
- Profile* profile;
-
// Refers to a navigation that was parked in the browser in order to be
// transferred to another RVH. Only used in case of a redirection of a request
// to a different site that created a new RVH.
« no previous file with comments | « chrome/browser/platform_util_chromeos.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698