Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: content/public/browser/android/content_view_core.h

Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase number deux Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/android/content_view.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/android/content_view_core.h
diff --git a/content/public/browser/android/content_view.h b/content/public/browser/android/content_view_core.h
similarity index 53%
rename from content/public/browser/android/content_view.h
rename to content/public/browser/android/content_view_core.h
index 95d1fbfaa44cb993ebf20448672ee2758216383d..d15c1690093b83fa48536c29bfe8e6af8b0b10ed 100644
--- a/content/public/browser/android/content_view.h
+++ b/content/public/browser/android/content_view_core.h
@@ -2,8 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
-#define CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
+#ifndef CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
+#define CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
+#pragma once
#include <jni.h>
@@ -13,27 +14,27 @@ namespace content {
class WebContents;
-// Native side of the ContentView.java, the primary FrameLayout of
-// Chromium on Android. This is a public interface used by native
-// code outside of the content module.
+// Native side of the ContentViewCore.java, which is the primary way of
+// communicating with the native Chromium code on Android. This is a
+// public interface used by native code outside of the content module.
//
// TODO(jrg): this is a shell. Upstream the rest.
//
// TODO(jrg): downstream, this class derives from
-// base::SupportsWeakPtr<ContentView>. Issues raised in
+// base::SupportsWeakPtr<ContentViewCore>. Issues raised in
// http://codereview.chromium.org/10536066/ make us want to rethink
// ownership issues.
// FOR THE MERGE (downstream), re-add derivation from
-// base::SupportsWeakPtr<ContentView> to keep everything else working
+// base::SupportsWeakPtr<ContentViewCore> to keep everything else working
// until this issue is resolved.
// http://b/6666045
-class ContentView {
+class ContentViewCore {
public:
virtual void Destroy(JNIEnv* env, jobject obj) = 0;
- static ContentView* Create(JNIEnv* env, jobject obj,
- WebContents* web_contents);
- static ContentView* GetNativeContentView(JNIEnv* env, jobject obj);
+ static ContentViewCore* Create(JNIEnv* env, jobject obj,
+ WebContents* web_contents);
+ static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);
// --------------------------------------------------------------------------
// Public methods that call to Java via JNI
@@ -42,9 +43,9 @@ class ContentView {
virtual void StartContentIntent(const GURL& content_url) = 0;
protected:
- virtual ~ContentView() {};
+ virtual ~ContentViewCore() {};
};
}; // namespace content
-#endif // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
+#endif // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_CORE_H_
« no previous file with comments | « content/public/browser/android/content_view.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698