Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 10696172: Allow unit tests to run in a sub thread for chrome on android (Closed)

Created:
8 years, 5 months ago by qinmin
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, bulach, jrg
CC:
chromium-reviews
Visibility:
Public.

Description

Allow unit tests to run in a sub thread for chrome on android Some of the tests, such as layout tests, need to run on a seperate thread. Adding an extra to the intent to achieve this. When invoking the test, users can use 'adb shell am start -e RunInSubThread -n testName' BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qinmin
8 years, 5 months ago (2012-07-11 16:29:57 UTC) #1
John Grabowski
LGTM
8 years, 5 months ago (2012-07-11 20:32:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/10696172/1
8 years, 5 months ago (2012-07-11 20:33:24 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 22:03:49 UTC) #4
Change committed as 146220

Powered by Google App Engine
This is Rietveld 408576698