Issue 10696163: [Sync] Check if bookmark exists before attempting favicon update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10696163: [Sync] Check if bookmark exists before attempting favicon update (Closed)

Created:
8 years, 5 months ago by Nicolas Zea

Modified:
8 years, 5 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Check if bookmark exists before attempting favicon update Favicon updates are per-url, and originate from a different thread. It's possible by the time we receive an update notification we've already deleted that bookmark, and should handle that situation gracefully. BUG=121587 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146032

Patch Set 1 #

Patch Set 2 : Add unit test #

Patch Set 3 : Fix #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -49 lines)			Patch
	M	chrome/browser/sync/glue/bookmark_change_processor.cc	View	1 2	3 chunks	+9 lines, -49 lines	0 comments	Download
	M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10696163/6001

8 years, 5 months ago (2012-07-10 23:10:23 UTC) #3

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

8 years, 5 months ago (2012-07-11 00:53:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10696163/6001

8 years, 5 months ago (2012-07-11 01:08:24 UTC) #5

Change committed as 146032

Expand Messages | Collapse Messages