[Sync] Check if bookmark exists before attempting favicon update

chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(akalin): This file is basically just a unit test for
 // BookmarkChangeProcessor.  Write unit tests for
 // BookmarkModelAssociator separately.
 
 #include <stack>
 #include <vector>
@@ skipping 525 matching lines @@
   int64 other_bookmarks_id() {
     return
         model_associator_->GetSyncIdFromChromeId(model_->other_node()->id());
   }
 
   int64 bookmark_bar_id() {
     return model_associator_->GetSyncIdFromChromeId(
         model_->bookmark_bar_node()->id());
   }
 
+  int64 GetSyncIdFromChromeNode(const BookmarkNode* node) {
+    return model_associator_->GetSyncIdFromChromeId(node->id());
+  }
+
  private:
   // Used by both |ui_thread_| and |file_thread_|.
   MessageLoop message_loop_;
   content::TestBrowserThread ui_thread_;
   // Needed by |model_|.
   content::TestBrowserThread file_thread_;
 
   TestingProfile profile_;
   scoped_ptr<TestBookmarkModelAssociator> model_associator_;
 
@@ skipping 932 matching lines @@
 
   StartSync();
 
   EXPECT_EQ(1, observer.get_started());
   EXPECT_EQ(0, observer.get_completed_count_at_started());
   EXPECT_EQ(1, observer.get_completed());
 
   model_->RemoveObserver(&observer);
 }
 
+TEST_F(ProfileSyncServiceBookmarkTest, FaviconUpdateToDeletedBookmark) {
+  LoadBookmarkModel(DELETE_EXISTING_STORAGE, DONT_SAVE_TO_STORAGE);
+  const BookmarkNode* bnode = model_->AddURL(
+      model_->bookmark_bar_node(),
+      0,
+      ASCIIToUTF16("Internets #1 Pies Site"),
+      GURL("http://www.easypie.com/"));
+  StartSync();
+
+  {
+    syncer::WriteTransaction trans(FROM_HERE, test_user_share_.user_share());
+    FakeServerChange dels(&trans);
+    dels.Delete(GetSyncIdFromChromeNode(bnode));
+    dels.ApplyPendingChanges(change_processor_.get());
+  }
+
+  // Now update the favicon locally. This should have no effect, but should
+  // not result in an error either.
+  change_processor_->BookmarkNodeFaviconChanged(model_, bnode);
+}
+
 }  // namespace
 
 }  // namespace browser_sync