Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(85)

Issue 10696152: Merge 121722 - Position replaced elements on pixel bounds (Closed)

Created:
8 years, 7 months ago by karen
Modified:
8 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 121722 - Position replaced elements on pixel bounds https://bugs.webkit.org/show_bug.cgi?id=90354 Reviewed by Eric Seidel. To avoid sizing and repaint issues we should layout replaced elements on pixel bounds. We already ensure that replaced elements are sized in full pixels and that they are painted on pixel bounds. By also ensuring that they are placed on pixel bounds we avoid pixel having the size be expanded by pixel snapping and repainting/invalidation rect issues when scrolling. Test: fast/repaint/repaint-during-scroll-with-zoom.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computePositionedLogicalWidthReplaced): (WebCore::RenderBox::computePositionedLogicalHeightReplaced): TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
A + LayoutTests/fast/repaint/repaint-during-scroll-with-zoom.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/box-sizing/box-sizing-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-win/media/media-document-audio-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 7 months ago (2012-07-10 18:39:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698