Source/WebCore/rendering/RenderBox.cpp - Issue 10696152: Merge 121722 - Position replaced elements on pixel bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/RenderBox.cpp

Issue 10696152: Merge 121722 - Position replaced elements on pixel bounds (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/rendering/RenderBox.cpp

===================================================================

--- Source/WebCore/rendering/RenderBox.cpp (revision 122238)

+++ Source/WebCore/rendering/RenderBox.cpp (working copy)

@@ -3258,7 +3258,7 @@

LayoutUnit logicalLeftPos = logicalLeftValue + marginLogicalLeftAlias;

computeLogicalLeftPositionedOffset(logicalLeftPos, this, logicalWidth(), containerBlock, containerLogicalWidth);

- setLogicalLeft(logicalLeftPos);

+ setLogicalLeft(logicalLeftPos.round());

}

void RenderBox::computePositionedLogicalHeightReplaced()

@@ -3387,7 +3387,7 @@

// Use computed values to calculate the vertical position.

LayoutUnit logicalTopPos = logicalTopValue + marginBeforeAlias;

computeLogicalTopPositionedOffset(logicalTopPos, this, logicalHeight(), containerBlock, containerLogicalHeight);

- setLogicalTop(logicalTopPos);

+ setLogicalTop(logicalTopPos.round());

}

LayoutRect RenderBox::localCaretRect(InlineBox* box, int caretOffset, LayoutUnit* extraWidthToEndOfLine)