Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4571)

Unified Diff: chrome/browser/ui/webui/sync_internals_ui.cc

Issue 10696107: sync: Track validity of about:sync fields (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_internals_ui.cc
diff --git a/chrome/browser/ui/webui/sync_internals_ui.cc b/chrome/browser/ui/webui/sync_internals_ui.cc
index 286fbff32b05ed8e9539bde72a38b14a9bc45fc5..5fbee10cc96465803544ea2ee44f7a78b7cda765 100644
--- a/chrome/browser/ui/webui/sync_internals_ui.cc
+++ b/chrome/browser/ui/webui/sync_internals_ui.cc
@@ -12,6 +12,7 @@
#include "base/tracked_objects.h"
#include "base/values.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sync/about_sync_util.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/sync/sync_ui_util.h"
@@ -109,11 +110,10 @@ bool SyncInternalsUI::OverrideHandleWebUIMessage(const GURL& source_url,
// the sync service doesn't exist.
if (name == "getAboutInfo") {
ListValue return_args;
- DictionaryValue* about_info = new DictionaryValue();
- return_args.Append(about_info);
Profile* profile = Profile::FromWebUI(web_ui());
ProfileSyncService* service = GetProfileSyncService(profile);
- sync_ui_util::ConstructAboutInformation(service, about_info);
+ return_args.Append(
+ sync_ui_util::ConstructAboutInformation(service).release());
HandleJsReply(name, JsArgList(&return_args));
} else {
if (js_controller_.get()) {
« no previous file with comments | « chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698