sync: Track validity of about:sync fields

chrome/browser/ui/webui/sync_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_internals_ui.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/tracked_objects.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sync/about_sync_util.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/sync/sync_ui_util.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
@@ skipping 77 matching lines @@
                                                  const std::string& name,
                                                  const ListValue& content) {
   scoped_ptr<ListValue> content_copy(content.DeepCopy());
   JsArgList args(content_copy.get());
   VLOG(1) << "Received message: " << name << " with args "
           << args.ToString();
   // We handle this case directly because it needs to work even if
   // the sync service doesn't exist.
   if (name == "getAboutInfo") {
     ListValue return_args;
-    DictionaryValue* about_info = new DictionaryValue();
-    return_args.Append(about_info);
     Profile* profile = Profile::FromWebUI(web_ui());
     ProfileSyncService* service = GetProfileSyncService(profile);
-    sync_ui_util::ConstructAboutInformation(service, about_info);
+    return_args.Append(
+        sync_ui_util::ConstructAboutInformation(service).release());
     HandleJsReply(name, JsArgList(&return_args));
   } else {
     if (js_controller_.get()) {
       js_controller_->ProcessJsMessage(
           name, args,
           MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()));
     } else {
       LOG(WARNING) << "No sync service; dropping message " << name
                    << " with args " << args.ToString();
     }
@@ skipping 11 matching lines @@
 }
 
 void SyncInternalsUI::HandleJsReply(
     const std::string& name, const JsArgList& args) {
   VLOG(1) << "Handling reply for " << name << " message with args "
           << args.ToString();
   const std::string& reply_handler = "chrome.sync." + name + ".handleReply";
   std::vector<const Value*> arg_list(args.Get().begin(), args.Get().end());
   web_ui()->CallJavascriptFunction(reply_handler, arg_list);
 }