Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 10696043: Shifted DownloadFile to exporting DownloadInterruptReasons. (Closed)

Created:
8 years, 5 months ago by Randy Smith (Not in Mondays)
Modified:
8 years, 5 months ago
Reviewers:
benjhayden, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Shifted DownloadFile to exporting DownloadInterruptReasons. DownloadFile used to return net::Errors (as BaseFile does). With the folding of functionality from the DownloadFileManager implied by the ByteStream refactor (the DownloadFile gives completion messages directly to the DownloadManager), it exported some DownloadInterruptReasons. This CL takes it the rest of the way. BUG=123998 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145376

Patch Set 1 #

Patch Set 2 : Sync'd to top of tree. #

Patch Set 3 : Sync'd to LKGR. #

Patch Set 4 : Sync'd to TOT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -97 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 14 chunks +15 lines, -15 lines 0 comments Download
M content/browser/download/download_file.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/download_file_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 1 2 3 4 chunks +17 lines, -14 lines 0 comments Download
M content/browser/download/download_file_manager.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/download/download_file_manager_unittest.cc View 9 chunks +27 lines, -17 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M content/browser/download/mock_download_file.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/mock_download_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_file_error_injector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_file_error_injector.cc View 4 chunks +28 lines, -23 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Randy Smith (Not in Mondays)
Ben: I've been asking Asanka for a lot of reviews recently, so I'm going to ...
8 years, 5 months ago (2012-06-29 03:06:34 UTC) #1
benjhayden
lgtm
8 years, 5 months ago (2012-06-29 15:57:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10696043/1
8 years, 5 months ago (2012-07-02 15:44:20 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/browser/download/download_file_manager.cc: While running patch -p1 --forward --force; patching file content/browser/download/download_file_manager.cc ...
8 years, 5 months ago (2012-07-02 15:44:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10696043/9001
8 years, 5 months ago (2012-07-02 20:17:16 UTC) #5
commit-bot: I haz the power
Presubmit check for 10696043-9001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-02 20:17:23 UTC) #6
Randy Smith (Not in Mondays)
Sky, Rubbertamp?
8 years, 5 months ago (2012-07-02 20:33:05 UTC) #7
Randy Smith (Not in Mondays)
I think Scott's on vacation. Jay, can I get a rubberstamp for the test directories ...
8 years, 5 months ago (2012-07-03 15:29:06 UTC) #8
Jay Civelli
lgtm
8 years, 5 months ago (2012-07-03 17:13:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10696043/9001
8 years, 5 months ago (2012-07-03 17:22:52 UTC) #10
commit-bot: I haz the power
Failed to apply patch for content/browser/download/download_file_impl.cc: While running patch -p1 --forward --force; patching file content/browser/download/download_file_impl.cc ...
8 years, 5 months ago (2012-07-03 17:22:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10696043/1013
8 years, 5 months ago (2012-07-03 17:57:09 UTC) #12
commit-bot: I haz the power
Failed to apply patch for content/browser/download/download_file_impl.cc: While running patch -p1 --forward --force; patching file content/browser/download/download_file_impl.cc ...
8 years, 5 months ago (2012-07-03 17:57:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10696043/9002
8 years, 5 months ago (2012-07-03 18:10:08 UTC) #14
commit-bot: I haz the power
Try job failure for 10696043-9002 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-07-03 18:55:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10696043/9002
8 years, 5 months ago (2012-07-03 19:42:32 UTC) #16
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 20:47:41 UTC) #17
Change committed as 145376

Powered by Google App Engine
This is Rietveld 408576698