Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 10695197: Handle setters on the prototype chain efficiently by default. (Closed)

Created:
8 years, 5 months ago by Sven Panne
Modified:
8 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Handle setters on the prototype chain efficiently by default. Note that changes on the prototype chain should already be handled by StubCompiler::CheckPrototypes, if not, it is a bug there and not in LookupForWrite. Furthermore, neither test262 nor WebKit layout tests hint at a compability issue, so it should be safe to remove a redundant check. The good point about this CL: It improves Box2D's performance by 22%. Committed: https://code.google.com/p/v8/source/detail?r=12079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/ic.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 5 months ago (2012-07-13 09:33:53 UTC) #1
rossberg
8 years, 5 months ago (2012-07-13 09:35:02 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698