Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: src/ic.cc

Issue 10695197: Handle setters on the prototype chain efficiently by default. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index d75b3e9799abae97e9fad7e6fc99c66bf99b209d..a6b7a1df8c7a3a98535cb835ebf91cda33c5e912 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1316,11 +1316,9 @@ static bool LookupForWrite(Handle<JSObject> receiver,
LookupResult* lookup) {
receiver->LocalLookup(*name, lookup);
if (!StoreICableLookup(lookup)) {
- // 2nd chance: There can be accessors somewhere in the prototype chain, but
- // for compatibility reasons we have to hide this behind a flag. Note that
- // we explicitly exclude native accessors for now, because the stubs are not
- // yet prepared for this scenario.
- if (!FLAG_es5_readonly) return false;
+ // 2nd chance: There can be accessors somewhere in the prototype chain. Note
+ // that we explicitly exclude native accessors for now, because the stubs
+ // are not yet prepared for this scenario.
receiver->Lookup(*name, lookup);
if (!lookup->IsCallbacks()) return false;
Handle<Object> callback(lookup->GetCallbackObject());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698