Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10695172: Allow Objective-C files in base/test/. (Closed)

Created:
8 years, 5 months ago by leng
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Allow Objective-C files in base/test/. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
leng
This change is required for for https://chromiumcodereview.appspot.com/10690161/ In order for gtests to run on iOS, ...
8 years, 5 months ago (2012-07-12 08:57:57 UTC) #1
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-12 13:38:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10695172/1
8 years, 5 months ago (2012-07-12 13:45:10 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 15:12:56 UTC) #4 
Change committed as 146348

Powered by Google App Engine
This is Rietveld 408576698