Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: base/PRESUBMIT.py

Issue 10695172: Allow Objective-C files in base/test/. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Chromium presubmit script for src/base. 5 """Chromium presubmit script for src/base.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl. 8 for more details on the presubmit API built into gcl.
9 """ 9 """
10 10
11 def _CheckNoInterfacesInBase(input_api, output_api): 11 def _CheckNoInterfacesInBase(input_api, output_api):
12 """Checks to make sure no files in libbase.a have |@interface|.""" 12 """Checks to make sure no files in libbase.a have |@interface|."""
13 pattern = input_api.re.compile(r'^\s*@interface', input_api.re.MULTILINE) 13 pattern = input_api.re.compile(r'^\s*@interface', input_api.re.MULTILINE)
14 files = [] 14 files = []
15 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): 15 for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
16 if (f.LocalPath().startswith('base/') and 16 if (f.LocalPath().startswith('base/') and
17 not "/test/" in f.LocalPath() and
17 not f.LocalPath().endswith('_unittest.mm')): 18 not f.LocalPath().endswith('_unittest.mm')):
18 contents = input_api.ReadFile(f) 19 contents = input_api.ReadFile(f)
19 if pattern.search(contents): 20 if pattern.search(contents):
20 files.append(f) 21 files.append(f)
21 22
22 if len(files): 23 if len(files):
23 return [ output_api.PresubmitError( 24 return [ output_api.PresubmitError(
24 'Objective-C interfaces or categories are forbidden in libbase. ' + 25 'Objective-C interfaces or categories are forbidden in libbase. ' +
25 'See http://groups.google.com/a/chromium.org/group/chromium-dev/' + 26 'See http://groups.google.com/a/chromium.org/group/chromium-dev/' +
26 'browse_thread/thread/efb28c10435987fd', 27 'browse_thread/thread/efb28c10435987fd',
(...skipping 18 matching lines...) Expand all
45 results.extend(_CommonChecks(input_api, output_api)) 46 results.extend(_CommonChecks(input_api, output_api))
46 return results 47 return results
47 48
48 49
49 def GetPreferredTrySlaves(): 50 def GetPreferredTrySlaves():
50 return [ 51 return [
51 'linux_rel:sync_integration_tests', 52 'linux_rel:sync_integration_tests',
52 'mac_rel:sync_integration_tests', 53 'mac_rel:sync_integration_tests',
53 'win_rel:sync_integration_tests', 54 'win_rel:sync_integration_tests',
54 ] 55 ]
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698