Fix: file permissions when restoring a page with file inputs with selected files.

Fix: file permissions when restoring a page with file inputs with selected files.

BUG=135605
TEST=GlueSerializeTest.FilePathsFromInputsInHistoryState


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152848

[marja, 2012-07-05 13:11:07]

This CL fixes a bug where file permissions were not set up properly after
restoring a page which contains file inputs with files selected.

Please review:

brettw: webkit/glue/*
sky: chrome/browser/sessions/*

[brettw, 2012-07-11 00:02:42]

http://codereview.chromium.org/10695107/diff/1/webkit/glue/glue_serialize.cc
File webkit/glue/glue_serialize.cc (right):

http://codereview.chromium.org/10695107/diff/1/webkit/glue/glue_serialize.cc#...
webkit/glue/glue_serialize.cc:585: // For each document element, the vector
contains the following entries:
WE don't want to do this type of manual parsing where we assume a certain
serialization format that WebKit might do. You can see that the
FilePathsFromHistoryState uses aonly WebKit API functions to do what it needs.
We should do the same here, adding them if what we need doesn't exist.

[marja, 2012-08-22 09:04:28]

brettw: could you have another look?

The WebKit api additions are now in, and this CL is ready for review again.

http://codereview.chromium.org/10695107/diff/1/webkit/glue/glue_serialize.cc
File webkit/glue/glue_serialize.cc (right):

http://codereview.chromium.org/10695107/diff/1/webkit/glue/glue_serialize.cc#...
webkit/glue/glue_serialize.cc:585: // For each document element, the vector
contains the following entries:
On 2012/07/11 00:02:42, brettw wrote:
> WE don't want to do this type of manual parsing where we assume a certain
> serialization format that WebKit might do. You can see that the
> FilePathsFromHistoryState uses aonly WebKit API functions to do what it needs.
> We should do the same here, adding them if what we need doesn't exist.

Done.

[brettw, 2012-08-22 18:24:20]

lgtm

[commit-bot: I haz the power, 2012-08-22 19:46:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10695107/18004

[commit-bot: I haz the power, 2012-08-22 22:46:19]

Change committed as 152848