Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/browser/download/download_manager_impl.h

Issue 10695087: Kill DownloadManagerImpl::save_page_downloads_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl.h
diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h
index 63d44672539b5f730f2a7b22ae81e67b31e298c7..ad799357b57280b9ee13e278101be402787207a9 100644
--- a/content/browser/download/download_manager_impl.h
+++ b/content/browser/download/download_manager_impl.h
@@ -187,10 +187,10 @@ class CONTENT_EXPORT DownloadManagerImpl
int32 download_id, content::DownloadInterruptReason reason);
// Called when a download entry is committed to the persistent store.
- void OnDownloadItemAddedToPersistentStore(int32 download_id, int64 db_handle);
+ void OnDownloadItemAddedToPersistentStore(content::DownloadItem* item);
// Called when Save Page As entry is committed to the persistent store.
- void OnSavePageItemAddedToPersistentStore(int32 download_id, int64 db_handle);
+ void OnSavePageItemAddedToPersistentStore(content::DownloadItem* item);
// Factory for creation of downloads items.
scoped_ptr<content::DownloadItemFactory> factory_;
@@ -209,11 +209,6 @@ class CONTENT_EXPORT DownloadManagerImpl
// processed. The key is the ID assigned by the DownloadFileManager,
// which is unique for the current session.
//
- // |save_page_downloads_| (if defined) is a collection of all the
- // downloads the "save page as" system has given to us to hold onto
- // until we are destroyed. They key is DownloadFileManager, so it is unique
- // compared to download item. It is only used for debugging.
- //
// When a download is created through a user action, the corresponding
// DownloadItem* is placed in |active_downloads_| and remains there until the
// download is in a terminal state (COMPLETE or CANCELLED). Once it has a
@@ -224,7 +219,6 @@ class CONTENT_EXPORT DownloadManagerImpl
DownloadMap downloads_;
DownloadMap active_downloads_;
- DownloadMap save_page_downloads_;
int history_size_;
« no previous file with comments | « no previous file | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698