Kill DownloadManagerImpl::save_page_downloads_

content/browser/download/download_manager_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_
 
 #include <map>
 #include <set>
 
@@ skipping 169 matching lines @@
   // Remove from internal maps.
   int RemoveDownloadItems(const DownloadVector& pending_deletes);
 
   // Called in response to our request to the DownloadFileManager to
   // create a DownloadFile.  A |reason| of
   // content::DOWNLOAD_INTERRUPT_REASON_NONE indicates success.
   void OnDownloadFileCreated(
       int32 download_id, content::DownloadInterruptReason reason);
 
   // Called when a download entry is committed to the persistent store.
-  void OnDownloadItemAddedToPersistentStore(int32 download_id, int64 db_handle);
+  void OnDownloadItemAddedToPersistentStore(content::DownloadItem* item);
 
   // Called when Save Page As entry is committed to the persistent store.
-  void OnSavePageItemAddedToPersistentStore(int32 download_id, int64 db_handle);
+  void OnSavePageItemAddedToPersistentStore(content::DownloadItem* item);
 
   // Factory for creation of downloads items.
   scoped_ptr<content::DownloadItemFactory> factory_;
 
   // |downloads_| is the owning set for all downloads known to the
   // DownloadManager.  This includes downloads started by the user in
   // this session, downloads initialized from the history system, and
   // "save page as" downloads.  All other DownloadItem containers in
   // the DownloadManager are maps; they do not own the DownloadItems.
   // Note that this is the only place (with any functional implications;
   // see save_page_downloads_ below) that "save page as" downloads are
   // kept, as the DownloadManager's only job is to hold onto those
   // until destruction.
   //
   // |active_downloads_| is a map of all downloads that are currently being
   // processed. The key is the ID assigned by the DownloadFileManager,
   // which is unique for the current session.
   //
-  // |save_page_downloads_| (if defined) is a collection of all the
-  // downloads the "save page as" system has given to us to hold onto
-  // until we are destroyed. They key is DownloadFileManager, so it is unique
-  // compared to download item. It is only used for debugging.
-  //
   // When a download is created through a user action, the corresponding
   // DownloadItem* is placed in |active_downloads_| and remains there until the
   // download is in a terminal state (COMPLETE or CANCELLED).  Once it has a
   // valid handle, the DownloadItem* is placed in the |history_downloads_| map.
   // Downloads from past sessions read from a persisted state from the history
   // system are placed directly into |history_downloads_| since they have valid
   // handles in the history system.
 
   DownloadMap downloads_;
   DownloadMap active_downloads_;
-  DownloadMap save_page_downloads_;
 
   int history_size_;
 
   // True if the download manager has been initialized and requires a shutdown.
   bool shutdown_needed_;
 
   // Observers that want to be notified of changes to the set of downloads.
   ObserverList<Observer> observers_;
 
   // The current active browser context.
   content::BrowserContext* browser_context_;
 
   // Non-owning pointer for handling file writing on the download_thread_.
   DownloadFileManager* file_manager_;
 
   // The user's last choice for download directory. This is only used when the
   // user wants us to prompt for a save location for each download.
   FilePath last_download_path_;
 
   // Allows an embedder to control behavior. Guaranteed to outlive this object.
   content::DownloadManagerDelegate* delegate_;
 
   net::NetLog* net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManagerImpl);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_