chrome/browser/extensions/api/extension_action/extension_actions_api.h - Issue 10695070: Implement scriptBadge.requestToAct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.h

Issue 10695070: Implement scriptBadge.requestToAct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix more of Aaron's comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/extension_action/extension_actions_api.cc » ('j') | chrome/browser/extensions/api/extension_action/extension_script_badge_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_actions_api.h

diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_actions_api.h

index 5ab8043412919f25377ee8bbb310e428678250ac..fe13cd3f1094ae468cbd3c1263f09b737dc200b7 100644

--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.h

+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.h

@@ -11,6 +11,7 @@

namespace base {

class DictionaryValue;

}

+class ExtensionTabHelper;

class TabContents;

// Implementation of the browserAction, pageAction, and scriptBadge APIs.

@@ -34,6 +35,10 @@ class ExtensionActionFunction : public SyncExtensionFunction {

void NotifyLocationBarChange();

bool SetVisible(bool visible);

+ // Extension-related information for |tab_id_|.

+ // CHECK-fails if there is no tab.

+ ExtensionTabHelper& tab_helper() const;

// All the extension action APIs take a single argument called details that

// is a dictionary.

base::DictionaryValue* details_;