chrome/browser/extensions/api/extension_action/extension_actions_api.cc - Issue 10695070: Implement scriptBadge.requestToAct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 10695070: Implement scriptBadge.requestToAct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix more of Aaron's comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_actions_api.h ('k') | chrome/browser/extensions/api/extension_action/extension_script_badge_api.h » ('j') | chrome/browser/extensions/api/extension_action/extension_script_badge_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

index 0a3779d9eb01389c517300e11ff81906c72b0ac9..fce3973d9ff272fec8cc7258f310369463b5b645 100644

--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

@@ -183,6 +183,11 @@ bool ExtensionActionFunction::SetVisible(bool visible) {

return true;

}

+ExtensionTabHelper& ExtensionActionFunction::tab_helper() const {

+ CHECK(contents_);

+ return *contents_->extension_tab_helper();

bool ExtensionActionShowFunction::RunExtensionAction() {

return SetVisible(true);

}