Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7022)

Unified Diff: chrome/common/extensions/api/script_badge.json

Issue 10695070: Implement scriptBadge.requestToAct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/script_badge.json
diff --git a/chrome/common/extensions/api/script_badge.json b/chrome/common/extensions/api/script_badge.json
index 4cba6966207b5951a1db2d01c1b0188e253b24c9..7d2305fe630f42dcbb3724a940997632e5b0ba64 100644
--- a/chrome/common/extensions/api/script_badge.json
+++ b/chrome/common/extensions/api/script_badge.json
@@ -51,6 +51,23 @@
]
}
]
+ },
+ {
+ "name": "requestToAct",
Aaron Boodman 2012/07/03 01:29:31 Despite my previous statements, I think we should
Jeffrey Yasskin 2012/07/10 21:52:33 Done.
+ "type": "function",
+ "description": "Shows a greyed-out script badge in order to ask permission to run on this tab. If the user clicks on the badge, the activeTab APIs become available. If the extension already has permission to run on this tab, or the tab is privileged so that the extension could never run on it, this call does nothing.",
Aaron Boodman 2012/07/03 01:29:31 Don't think we should commit to exact presentation
Aaron Boodman 2012/07/03 01:29:31 I don't think we should do anything special if the
Jeffrey Yasskin 2012/07/10 21:52:33 Done.
Jeffrey Yasskin 2012/07/10 21:52:33 If the extension has already run script, we'd have
Aaron Boodman 2012/07/10 22:50:46 If the script badge is already showing, I think th
Jeffrey Yasskin 2012/07/16 21:33:37 I've removed the "for now" about this.
+ "parameters": [
+ {
+ "name": "details",
+ "type": "object",
+ "properties": {
+ "tabId": {
+ "type": "integer",
+ "description": "Specify the tab to request to act on."
+ }
+ }
+ }
+ ]
}
],
"events": [

Powered by Google App Engine
This is Rietveld 408576698