chrome/browser/ui/views/select_file_dialog_extension.cc - Issue 10695066: Move SelectFileDialog implementation to ui/base/dialogs/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.cc

Issue 10695066: Move SelectFileDialog implementation to ui/base/dialogs/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reupload because weirdness Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/select_file_dialog_extension.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc

index 0f9cbfbcc634d3180de859d45d09337eed3f5e8b..655b8d3b94220a114d2abaf5b6cb68b7701bcc82 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension.cc

@@ -80,6 +80,7 @@ scoped_refptr<SelectFileDialogExtension> PendingDialog::Find(int32 tab_id) {

} // namespace

+/*

James Cook 2012/07/11 22:34:14 Did you mean to leave this in?

// Linking this implementation of SelectFileDialog::Create into the target

// selects FileManagerDialog as the dialog of choice.

// TODO(jamescook): Move this into a new file shell_dialogs_chromeos.cc

@@ -91,6 +92,7 @@ SelectFileDialog* SelectFileDialog::Create(Listener* listener,

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

return SelectFileDialogExtension::Create(listener, policy);

}

+*/

/////////////////////////////////////////////////////////////////////////////