Issue 10694126: Revert 146032 - [Sync] Check if bookmark exists before attempting favicon update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10694126: Revert 146032 - [Sync] Check if bookmark exists before attempting favicon update (Closed)

Created:
8 years, 5 months ago by Nicolas Zea

Modified:
8 years, 5 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 146032 - [Sync] Check if bookmark exists before attempting favicon update Favicon updates are per-url, and originate from a different thread. It's possible by the time we receive an update notification we've already deleted that bookmark, and should handle that situation gracefully. BUG=121587 TEST= Review URL: https://chromiumcodereview.appspot.com/10696163 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146040

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -34 lines)			Patch
	M	chrome/browser/sync/glue/bookmark_change_processor.cc	View		3 chunks	+49 lines, -9 lines	0 comments	Download
	M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View		2 chunks	+0 lines, -25 lines	0 comments	Download

Total messages: 1 (0 generated)