chrome/browser/extensions/platform_app_browsertest_util.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/platform_app_browsertest_util.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_function.cc ('K') | « chrome/browser/extensions/extension_processes_api.cc ('k') | chrome/browser/extensions/settings/settings_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/platform_app_browsertest_util.cc

diff --git a/chrome/browser/extensions/platform_app_browsertest_util.cc b/chrome/browser/extensions/platform_app_browsertest_util.cc

index 1fe12ea0a2761d2827e20107e6a4aead678134dc..ba4f091eb1792225721909c5a83414007cb41c9e 100644

--- a/chrome/browser/extensions/platform_app_browsertest_util.cc

+++ b/chrome/browser/extensions/platform_app_browsertest_util.cc

@@ -68,7 +68,7 @@ size_t PlatformAppBrowserTest::RunGetWindowsFunctionForExtension(

GetAllWindowsFunction* function = new GetAllWindowsFunction();

function->set_extension(extension);

scoped_ptr<base::ListValue> result(utils::ToList(

- utils::RunFunctionAndReturnResult(function, "[]", browser())));

+ utils::RunFunctionAndReturnSingleResult(function, "[]", browser())));

return result->GetSize();

}

@@ -82,7 +82,7 @@ bool PlatformAppBrowserTest::RunGetWindowFunctionForExtension(

base::StringPrintf("[%u]", window_id),

browser(),

utils::NONE);

- return function->GetResultValue() != NULL;

+ return function->GetResultList() != NULL;

}

size_t PlatformAppBrowserTest::GetShellWindowCount() {