Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3489)

Unified Diff: chrome/browser/extensions/extension_processes_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_processes_api.cc
diff --git a/chrome/browser/extensions/extension_processes_api.cc b/chrome/browser/extensions/extension_processes_api.cc
index c853495044f9c3c11ad0113055e6e45bb48dcd29..47436ecda15fb4b3e067d705748cc2e39b21907c 100644
--- a/chrome/browser/extensions/extension_processes_api.cc
+++ b/chrome/browser/extensions/extension_processes_api.cc
@@ -568,11 +568,11 @@ void GetProcessIdForTabFunction::GetProcessIdForTab() {
error_ = ExtensionErrorUtils::FormatErrorMessage(
extensions::tabs_constants::kTabNotFoundError,
base::IntToString(tab_id_));
- result_.reset(Value::CreateIntegerValue(-1));
+ SetResult(Value::CreateIntegerValue(-1));
SendResponse(false);
} else {
int process_id = contents->web_contents()->GetRenderProcessHost()->GetID();
- result_.reset(Value::CreateIntegerValue(process_id));
+ SetResult(Value::CreateIntegerValue(process_id));
SendResponse(true);
}
@@ -644,7 +644,7 @@ void TerminateFunction::TerminateProcess() {
base::IntToString(process_id_));
SendResponse(false);
} else {
- result_.reset(Value::CreateBooleanValue(killed));
+ SetResult(Value::CreateBooleanValue(killed));
SendResponse(true);
}
@@ -744,7 +744,7 @@ void GetProcessInfoFunction::GatherProcessInfo() {
DCHECK(process_ids_.size() == 0);
}
- result_.reset(processes);
+ SetResult(processes);
SendResponse(true);
// Balance the AddRef in the RunImpl.

Powered by Google App Engine
This is Rietveld 408576698