Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/extensions/api/idltest/idltest_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/idltest/idltest_api.cc
diff --git a/chrome/browser/extensions/api/idltest/idltest_api.cc b/chrome/browser/extensions/api/idltest/idltest_api.cc
index 1feff0a8cd6af633729b3b9787f795eac2b661ad..744aa7969eba51c88e5b3bae1fc291488d3c1b2d 100644
--- a/chrome/browser/extensions/api/idltest/idltest_api.cc
+++ b/chrome/browser/extensions/api/idltest/idltest_api.cc
@@ -24,14 +24,14 @@ ListValue* CopyBinaryValueToIntegerList(const BinaryValue* input) {
bool IdltestSendArrayBufferFunction::RunImpl() {
BinaryValue* input = NULL;
EXTENSION_FUNCTION_VALIDATE(args_ != NULL && args_->GetBinary(0, &input));
- result_.reset(CopyBinaryValueToIntegerList(input));
+ SetResult(CopyBinaryValueToIntegerList(input));
return true;
}
bool IdltestSendArrayBufferViewFunction::RunImpl() {
BinaryValue* input = NULL;
EXTENSION_FUNCTION_VALIDATE(args_ != NULL && args_->GetBinary(0, &input));
- result_.reset(CopyBinaryValueToIntegerList(input));
+ SetResult(CopyBinaryValueToIntegerList(input));
return true;
}
@@ -39,6 +39,6 @@ bool IdltestGetArrayBufferFunction::RunImpl() {
std::string hello = "hello world";
BinaryValue* output =
BinaryValue::CreateWithCopiedBuffer(hello.c_str(), hello.size());
- result_.reset(output);
+ SetResult(output);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698