chrome/browser/extensions/api/identity/identity_api.cc - Issue 10694106: Added support for multiple parameters to Extension API callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_api.cc

Issue 10694106: Added support for multiple parameters to Extension API callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Synced. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | chrome/browser/extensions/api/idltest/idltest_api.cc » ('j') | chrome/browser/extensions/extension_function.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_api.cc

diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc

index 4333d3441d47617026dfdd2f4771ecbaf6907211..4536d76ab6e258c576e883c9a64feb4eac4586f4 100644

--- a/chrome/browser/extensions/api/identity/identity_api.cc

+++ b/chrome/browser/extensions/api/identity/identity_api.cc

@@ -52,7 +52,7 @@ bool GetAuthTokenFunction::RunImpl() {

}

void GetAuthTokenFunction::OnMintTokenSuccess(const std::string& access_token) {

- result_.reset(Value::CreateStringValue(access_token));

+ SetResult(Value::CreateStringValue(access_token));

SendResponse(true);

Release(); // Balanced in RunImpl.

}

@@ -147,7 +147,7 @@ bool LaunchWebAuthFlowFunction::RunImpl() {

void LaunchWebAuthFlowFunction::OnAuthFlowSuccess(

const std::string& redirect_url) {

- result_.reset(Value::CreateStringValue(redirect_url));

+ SetResult(Value::CreateStringValue(redirect_url));

SendResponse(true);

Release(); // Balanced in RunImpl.

}