Remove the force_session cookie option, as it's not used anymore

Remove the force_session cookie option, as it's not used anymore

BUG=133903
TEST=none

TBR=sky@chromium.org,wtc@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146121

[jochen (gone - plz use gerrit), 2012-07-06 09:08:20]

hey Marja,

can you do a first pass over this CL?

[marja, 2012-07-06 11:00:52]

lgtm

[jochen (gone - plz use gerrit), 2012-07-06 11:14:40]

Erik, please review

[erikwright (departed), 2012-07-06 13:54:51]

On holiday today. Will do Monday.
On Jul 6, 2012 7:14 AM, <jochen@chromium.org> wrote:

> Erik, please review
>
>
https://chromiumcodereview.**appspot.com/10694093/<https://chromiumcodereview...
>

[erikwright (departed), 2012-07-10 13:25:45]

One concern:

I think the callers of DoesExpire are really asking, "is this a session cookie".
So I suggest renaming that method to something out of:

IsSessionCookie
IsSession
IsPersistent

Obviously the first two imply reversing some logic tests. None of them seems
preferable to me, so whichever is more natural to you is the one I would take.

[jochen (gone - plz use gerrit), 2012-07-11 09:08:19]

I picked IsPersistent because it doesn't require a logic change, and we had that
method on CanonicalCookie before

[erikwright (departed), 2012-07-11 13:56:34]

LGTM with nit.

Thanks!

http://codereview.chromium.org/10694093/diff/1016/chrome/browser/net/sqlite_p...
File chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc (right):

http://codereview.chromium.org/10694093/diff/1016/chrome/browser/net/sqlite_p...
chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc:387:
TEST_F(SQLitePersistentCookieStoreTest, PersistHasExpires) {
nit: rename to PersistIsPersistent

[jochen (gone - plz use gerrit), 2012-07-11 14:16:13]

TBR'ing OWNERS as the owned files are only affected by changes in the
CanonicalCookie API

[commit-bot: I haz the power, 2012-07-11 14:16:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10694093/11002

[commit-bot: I haz the power, 2012-07-11 15:22:17]

Change committed as 146121