chrome/browser/ui/cocoa/content_settings/cookie_details.mm - Issue 10694093: Remove the force_session cookie option, as it's not used anymore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/cookie_details.mm

Issue 10694093: Remove the force_session cookie option, as it's not used anymore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/content_settings/cookie_details.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/cookie_details.mm b/chrome/browser/ui/cocoa/content_settings/cookie_details.mm

index 1b2a767f89395044c6c4e472ff04efad0ddffdeb..c36d084a28bd0358709cba80b07082082fd631b2 100644

--- a/chrome/browser/ui/cocoa/content_settings/cookie_details.mm

+++ b/chrome/browser/ui/cocoa/content_settings/cookie_details.mm

@@ -121,14 +121,14 @@

canEditExpiration:(BOOL)canEditExpiration {

if ((self = [super init])) {

type_ = kCocoaCookieDetailsTypeCookie;

- hasExpiration_ = cookie->DoesExpire();

+ hasExpiration_ = cookie->IsPersistent();

canEditExpiration_ = canEditExpiration && hasExpiration_;

name_.reset([base::SysUTF8ToNSString(cookie->Name()) retain]);

content_.reset([base::SysUTF8ToNSString(cookie->Value()) retain]);

path_.reset([base::SysUTF8ToNSString(cookie->Path()) retain]);

domain_.reset([origin retain]);

- if (cookie->DoesExpire()) {

+ if (cookie->IsPersistent()) {

expires_.reset([base::SysUTF16ToNSString(

base::TimeFormatFriendlyDateAndTime(cookie->ExpiryDate())) retain]);

} else {