Chromium Code Reviews
Help | Chromium Project | Sign in
(15)

Issue 10694051: Implement typedarray.set and arraybuffer.slice for d8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by rossberg
Modified:
1 year, 9 months ago
Reviewers:
Yang
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Implement typedarray.set and arraybuffer.slice for d8.

R=yangguo@chromium.org
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11983

Patch Set 1 #

Patch Set 2 : Handle overlapping for differing element sizes correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -24 lines) Lint Patch
M src/d8.h View 2 chunks +4 lines, -1 line 0 comments ? errors Download
M src/d8.cc View 1 12 chunks +235 lines, -23 lines 0 comments ? errors Download
M test/mjsunit/external-array.js View 1 1 chunk +98 lines, -0 lines 0 comments ? errors Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
rossberg
1 year, 9 months ago #1
Yang
1 year, 9 months ago #2
On 2012/07/02 13:55:18, rossberg wrote:

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6