Chromium Code Reviews
Help | Chromium Project | Sign in
(122)

Issue 10694051: Implement typedarray.set and arraybuffer.slice for d8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by rossberg
Modified:
2 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Implement typedarray.set and arraybuffer.slice for d8. R=yangguo@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11983

Patch Set 1 #

Patch Set 2 : Handle overlapping for differing element sizes correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -24 lines) Patch
M src/d8.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/d8.cc View 1 12 chunks +235 lines, -23 lines 0 comments Download
M test/mjsunit/external-array.js View 1 1 chunk +98 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
rossberg
2 years, 11 months ago (2012-07-02 13:55:18 UTC) #1
Yang
2 years, 10 months ago (2012-07-03 13:29:58 UTC) #2
On 2012/07/02 13:55:18, rossberg wrote:

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be