Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10694051: Implement typedarray.set and arraybuffer.slice for d8. (Closed)

Created:
8 years, 5 months ago by rossberg
Modified:
8 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Implement typedarray.set and arraybuffer.slice for d8. R=yangguo@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11983

Patch Set 1 #

Patch Set 2 : Handle overlapping for differing element sizes correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -24 lines) Patch
M src/d8.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/d8.cc View 1 12 chunks +235 lines, -23 lines 0 comments Download
M test/mjsunit/external-array.js View 1 1 chunk +98 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 5 months ago (2012-07-02 13:55:18 UTC) #1
Yang
8 years, 5 months ago (2012-07-03 13:29:58 UTC) #2
On 2012/07/02 13:55:18, rossberg wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698