Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 10694029: Change PRESUBMIT to try more cls on android (Closed)

Created:
8 years, 5 months ago by Isaac (away)
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Change PRESUBMIT to try more cls on android - android doesn't currently build anything in chrome/ so we're changing try job logic to send builds to android unless the CL was exclusively in chrome/ Previously we would have built on roughly 20% of cls with 'git try' After this change we will build on roughly 60% of cls (based on last 10k commits) BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144841

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M PRESUBMIT.py View 2 chunks +4 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Isaac (away)
8 years, 5 months ago (2012-06-28 22:34:15 UTC) #1
M-A Ruel
lgtm
8 years, 5 months ago (2012-06-28 22:36:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10694029/1
8 years, 5 months ago (2012-06-28 22:40:04 UTC) #3
John Grabowski
https://chromiumcodereview.appspot.com/10694029/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/10694029/diff/1/PRESUBMIT.py#newcode483 PRESUBMIT.py:483: if not files: unnecessary
8 years, 5 months ago (2012-06-28 22:48:41 UTC) #4
John Grabowski
https://chromiumcodereview.appspot.com/10694029/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/10694029/diff/1/PRESUBMIT.py#newcode483 PRESUBMIT.py:483: if not files: On 2012/06/28 22:48:41, John Grabowski wrote: ...
8 years, 5 months ago (2012-06-28 22:51:29 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-29 00:09:04 UTC) #6
Change committed as 144841

Powered by Google App Engine
This is Rietveld 408576698