Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: PRESUBMIT.py

Issue 10694029: Change PRESUBMIT to try more cls on android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 2c07248b8ae82a935b7b7d882e9a665620c91ce5..aaf6544260c0ae6a01f42962b3f13d33ad133ffc 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -480,6 +480,9 @@ def CheckChangeOnCommit(input_api, output_api):
def GetPreferredTrySlaves(project, change):
files = change.LocalPaths()
+ if not files:
John Grabowski 2012/06/28 22:48:41 unnecessary
John Grabowski 2012/06/28 22:51:29 Hmm... all([]) is True. Unexpected.
+ return []
+
if all(re.search('\.(m|mm)$|[/_]mac[/_.]', f) for f in files):
return ['mac_rel']
if all(re.search('[/_]win[/_.]', f) for f in files):
@@ -492,9 +495,7 @@ def GetPreferredTrySlaves(project, change):
if any(re.search('[/_]aura', f) for f in files):
trybots.append('linux_chromeos')
- # Ensure CL contains some relevant files (i.e. not purely ^chrome)
- if any(re.search('^(base|build|content|ipc|jingle|media|net|sql)/', f)
- for f in files):
+ if not all(f.startswith('chrome/') for f in files):
trybots.append('android')
return trybots
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698