Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 10694003: Use capturing with XGetImage() only in screenshot_taker. (Closed)

Created:
8 years, 5 months ago by Jun Mukai
Modified:
8 years, 5 months ago
Reviewers:
Daniel Erat, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Use capturing with XGetImage() only in screenshot_taker. GrabWindowSnapshot() happens in the "Report Issue" (c/b/ui/webui/feedback_ui.cc) and XGetImage runs earlier than closing the wrench menu. This could delay the response on "Report Issue" but it's much more important to work correctly for this specific item. R=derat@chromium.org BUG=134818 TEST=manually done on lumpy / selecting "Report Issue" and Ctrl-F5 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/ui/views/ash/screenshot_taker.cc View 3 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/ui/window_snapshot/window_snapshot_aura.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
8 years, 5 months ago (2012-06-27 09:41:07 UTC) #1
Daniel Erat
lgtm
8 years, 5 months ago (2012-06-27 13:46:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10694003/1
8 years, 5 months ago (2012-06-27 14:22:07 UTC) #3
commit-bot: I haz the power
Presubmit check for 10694003-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-06-27 14:22:15 UTC) #4
Jun Mukai
sky, please also see this as the OWNER
8 years, 5 months ago (2012-06-27 14:31:41 UTC) #5
sky
LGTM
8 years, 5 months ago (2012-06-27 16:28:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10694003/1
8 years, 5 months ago (2012-06-27 16:36:39 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 18:45:06 UTC) #8
Change committed as 144497

Powered by Google App Engine
This is Rietveld 408576698