Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 10693093: [Android] Fix command line path in flag_changer.py. (Closed)

Created:
8 years, 5 months ago by mkosiba (inactive)
Modified:
8 years, 5 months ago
Reviewers:
bulach, Sami
CC:
chromium-reviews, John Grabowski, digit1
Visibility:
Public.

Description

[Android] Fix command line path in flag_changer.py. In http://src.chromium.org/viewvc/chrome?view=rev&revision=144269 the command line path was accidentally changed to an incorrect value. This change fixes that and updates a stale comment in CommandLine.java. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145469

Patch Set 1 #

Patch Set 2 : also fix up stale comment in CommandLine.java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/flag_changer.py View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/common/CommandLine.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mkosiba (inactive)
8 years, 5 months ago (2012-07-04 13:40:13 UTC) #1
Sami
lgtm
8 years, 5 months ago (2012-07-04 13:58:18 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-04 14:03:54 UTC) #3
bulach
hmm.. the conflict comes from this patch, which also changed a few other places: https://chromiumcodereview.appspot.com/10566028/ ...
8 years, 5 months ago (2012-07-04 14:16:36 UTC) #4
mkosiba (inactive)
On 2012/07/04 14:16:36, bulach wrote: > hmm.. the conflict comes from this patch, which also ...
8 years, 5 months ago (2012-07-04 15:03:49 UTC) #5
bulach
lgtm ahn, thanks for the clarification! looks fine..
8 years, 5 months ago (2012-07-04 15:12:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10693093/5003
8 years, 5 months ago (2012-07-04 15:23:17 UTC) #7
commit-bot: I haz the power
Change committed as 145469
8 years, 5 months ago (2012-07-04 16:54:52 UTC) #8
gone
8 years, 5 months ago (2012-07-04 18:31:34 UTC) #9
On 2012/07/04 16:54:52, I haz the power (commit-bot) wrote:
> Change committed as 145469

Sorry about that... when I landed my upstream patch, both my upstream and
downstream versions of CommandLine.java were pointing at
/data/local/chrome-command-line.  It'd be nice to have a single place to pull
this value from.

Powered by Google App Engine
This is Rietveld 408576698