[Android] Upstreaming flag_changer.py

[Android] Upstreaming flag_changer.py

Upstreams one of the build scripts needed for Android.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144269

[gone, 2012-06-22 20:25:19]

PTAL

[John Grabowski, 2012-06-26 07:26:30]

https://chromiumcodereview.appspot.com/10657002/diff/1/build/android/flag_cha...
File build/android/flag_changer.py (right):

https://chromiumcodereview.appspot.com/10657002/diff/1/build/android/flag_cha...
build/android/flag_changer.py:10: CHROME_COMMAND_FILE =
'/data/local/chrome-command-line'
You changed the command line file from the default location without changing
code that finds this file.  Was that your intention?  Will things still work
with this change?

[gone, 2012-06-26 16:48:12]

On 2012/06/26 07:26:30, John Grabowski wrote:
>
https://chromiumcodereview.appspot.com/10657002/diff/1/build/android/flag_cha...
> File build/android/flag_changer.py (right):
> 
>
https://chromiumcodereview.appspot.com/10657002/diff/1/build/android/flag_cha...
> build/android/flag_changer.py:10: CHROME_COMMAND_FILE =
> '/data/local/chrome-command-line'
> You changed the command line file from the default location without changing
> code that finds this file.  Was that your intention?  Will things still work
> with this change?

The odd thing is that the command line file location in CommandLine.java (and
other places) points to /data/local/chrome-command-line and not
/data/local/tmp/chrome-command-line.  I think this file has been out of sync.

[John Grabowski, 2012-06-26 17:53:04]

OK then, LGTM

[commit-bot: I haz the power, 2012-06-26 18:26:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/10657002/1

[commit-bot: I haz the power, 2012-06-26 20:51:39]

Change committed as 144269