Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
===================================================================
--- chrome/test/base/in_process_browser_test.cc (revision 148382)
+++ chrome/test/base/in_process_browser_test.cc (working copy)
@@ -237,22 +237,22 @@
// Creates a browser with a single tab (about:blank), waits for the tab to
// finish loading and shows the browser.
Browser* InProcessBrowserTest::CreateBrowser(Profile* profile) {
- Browser* browser = Browser::Create(profile);
+ Browser* browser = new Browser(Browser::CreateParams(profile));
AddBlankTabAndShow(browser);
return browser;
}
Browser* InProcessBrowserTest::CreateIncognitoBrowser() {
// Create a new browser with using the incognito profile.
- Browser* incognito =
- Browser::Create(browser()->profile()->GetOffTheRecordProfile());
+ Browser* incognito = new Browser(
+ Browser::CreateParams(browser()->profile()->GetOffTheRecordProfile()));
AddBlankTabAndShow(incognito);
return incognito;
}
Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
- Browser* browser = Browser::CreateWithParams(
- Browser::CreateParams(Browser::TYPE_POPUP, profile));
+ Browser* browser =
+ new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile));
AddBlankTabAndShow(browser);
return browser;
}
@@ -260,7 +260,7 @@
Browser* InProcessBrowserTest::CreateBrowserForApp(
const std::string& app_name,
Profile* profile) {
- Browser* browser = Browser::CreateWithParams(
+ Browser* browser = new Browser(
Browser::CreateParams::CreateForApp(
Browser::TYPE_POPUP, app_name, gfx::Rect(), profile));
AddBlankTabAndShow(browser);
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698