Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 10692164: Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of met… (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of metro-specific code, already have a navigator. By moving the browser::FindTabbedBrowser call there, it's clear that in that spot we need to use the metro-specific context. BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -91 lines) Patch
M chrome/browser/bookmarks/bookmark_context_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 3 chunks +1 line, -55 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views_win.cc View 2 chunks +60 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 5 months ago (2012-07-11 18:06:34 UTC) #1
Ben Goodger (Google)
8 years, 5 months ago (2012-07-11 18:13:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698