Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 10692164: Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of met… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" 5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
6 6
7 #include "base/mac/bundle_locations.h" 7 #include "base/mac/bundle_locations.h"
8 #include "base/mac/mac_util.h" 8 #include "base/mac/mac_util.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/sys_string_conversions.h" 10 #include "base/sys_string_conversions.h"
(...skipping 2603 matching lines...) Expand 10 before | Expand all | Expand 10 after
2614 // No longer need to hold the lock; the folderController_ now owns it. 2614 // No longer need to hold the lock; the folderController_ now owns it.
2615 [browserController releaseBarVisibilityForOwner:self 2615 [browserController releaseBarVisibilityForOwner:self
2616 withAnimation:NO 2616 withAnimation:NO
2617 delay:NO]; 2617 delay:NO];
2618 } 2618 }
2619 2619
2620 - (void)openAll:(const BookmarkNode*)node 2620 - (void)openAll:(const BookmarkNode*)node
2621 disposition:(WindowOpenDisposition)disposition { 2621 disposition:(WindowOpenDisposition)disposition {
2622 [self closeFolderAndStopTrackingMenus]; 2622 [self closeFolderAndStopTrackingMenus];
2623 bookmark_utils::OpenAll([[self view] window], 2623 bookmark_utils::OpenAll([[self view] window],
2624 browser_->profile(),
2625 browser_, 2624 browser_,
2626 node, 2625 node,
2627 disposition); 2626 disposition);
2628 } 2627 }
2629 2628
2630 - (void)addButtonForNode:(const BookmarkNode*)node 2629 - (void)addButtonForNode:(const BookmarkNode*)node
2631 atIndex:(NSInteger)buttonIndex { 2630 atIndex:(NSInteger)buttonIndex {
2632 int newOffset = 0; 2631 int newOffset = 0;
2633 if (buttonIndex == -1) 2632 if (buttonIndex == -1)
2634 buttonIndex = [buttons_ count]; // New button goes at the end. 2633 buttonIndex = [buttons_ count]; // New button goes at the end.
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
2793 // to minimize touching the object passed in (likely a mock). 2792 // to minimize touching the object passed in (likely a mock).
2794 - (void)setButtonContextMenu:(id)menu { 2793 - (void)setButtonContextMenu:(id)menu {
2795 buttonContextMenu_ = menu; 2794 buttonContextMenu_ = menu;
2796 } 2795 }
2797 2796
2798 - (void)setIgnoreAnimations:(BOOL)ignore { 2797 - (void)setIgnoreAnimations:(BOOL)ignore {
2799 ignoreAnimations_ = ignore; 2798 ignoreAnimations_ = ignore;
2800 } 2799 }
2801 2800
2802 @end 2801 @end
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698