Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Issue 10692115: [WebUI] Narrow the scope of chrome/browser/resources/PRESUBMIT.py. (Closed)

Created:
8 years, 5 months ago by Dan Beam
Modified:
8 years, 5 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[WebUI] Narrow the scope of chrome/browser/resources/PRESUBMIT.py. Apparently any change in chrome/browser/resources will trigger this and includes paths outside of this (e.g. third_party/*). This changes the behavior to only look at chrome/browser/resources/*.{js,css} (recursively) like we original thought. See: https://chromiumcodereview.appspot.com/10679009/#msg21 for an example of why this is necessary. TBR=tbreisacher@chromium.org,estade@chromium.org BUG=113202 TEST=Changes to third_party or other unrelated paths don't get tons of presubmit errors. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dan Beam
8 years, 5 months ago (2012-07-07 04:23:52 UTC) #1
Dan Beam
+estade for OWNERS
8 years, 5 months ago (2012-07-07 04:25:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/10692115/1
8 years, 5 months ago (2012-07-07 04:26:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/10692115/1
8 years, 5 months ago (2012-07-07 04:28:50 UTC) #4
commit-bot: I haz the power
Change committed as 145625
8 years, 5 months ago (2012-07-07 04:28:56 UTC) #5
Tyler Breisacher (Chromium)
8 years, 5 months ago (2012-07-09 15:50:17 UTC) #6
lgtm, thanks.

Powered by Google App Engine
This is Rietveld 408576698