chrome/browser/resources/PRESUBMIT.py - Issue 10692115: [WebUI] Narrow the scope of chrome/browser/resources/PRESUBMIT.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 10692115: [WebUI] Narrow the scope of chrome/browser/resources/PRESUBMIT.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index 4487888f7a1da644522848910a357ce2dcbb45f4..ad761dfb69de8225bd832a13b91636524268ffdd 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -44,8 +44,9 @@ def _CommonChecks(input_api, output_api):

sys.path = [resources] + old_path

from web_dev_style import css_checker, js_checker

- def is_resource(f):

- return f.LocalPath().endswith(('.css', '.html', '.js'))

+ def is_resource(maybe_resource):

+ f = maybe_resource.AbsoluteLocalPath()

+ return f.endswith(('.css', '.html', '.js')) and f.startswith(resources)

results.extend(css_checker.CSSChecker(input_api, output_api,

file_filter=is_resource).RunChecks())

« no previous file with comments | « no previous file | no next file » | no next file with comments »