Some more changes that came out of writing an article on mocks.

Some more changes that came out of writing an article on mocks.

- wrap the matchers in anyOf/allOf
- add timestamps to log entries
- add ability to share logs
- changed 'called' to 'happened'; it scans better and makes more sense in throw cases
- added ability to pass an action matcher to getLogs
- moved getLogs back into Mock
Committed: https://code.google.com/p/dart/source/detail?r=9275

[gram, 2012-06-29 23:00:03]

Adding John - PTAL if interested.

[Jennifer Messerly, 2012-06-29 23:24:09]

this mocking lib looks awesome :)

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.dart
File lib/unittest/mock.dart (right):

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:44: final IGNORE = 0;
might want to wrap these in the enum pattern

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:45: final RETURN = 1;
also the ones after the first one could use doc comments

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:244: Date when; // The time of the event.
can this be final, and set it in an initializer:

LogEntry(this.mockName, ...) {
    : when = new Date.now();

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:252: this.args, this.action, [this.value = null]) {
nit: can write this as "[this.value]". The "= null" is implied now

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:265: int secs = (delta / 1000).toInt();
nit: delta ~/ 1000
also, shouldn't need .toInt, if you do that's a bug.

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:266: int msecs = (delta % 1000).toInt();
likewise, this shouldn't need .toInt

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:280: /** Utility function for optionally qualified method
names */
nit: extra newline here

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:382: /** [happenedExactly] matches an exact number of
calls. */
not sure you really need the link, since it's just linking to itself.

However, commenting on and linking to the other happened* matchers in prose
would be neat. (It might almost be worth making _TimesMatcher public, so you
have a class to put that commentary ... )

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:462: /** Special values for use with [_ResultSetMatcher]
[frequency]. */
probably shouldn't link to an internal type.
also, these could use individual doc comments or an enum pattern, so they'll be
grouped properly in our docs.

https://chromiumcodereview.appspot.com/10692051/diff/2001/lib/unittest/mock.d...
lib/unittest/mock.dart:784: throw new Exception('No more actions for method '
is there a more subtype of Exception we could throw here? (or should we create
one?)

https://chromiumcodereview.appspot.com/10692051/diff/2001/tests/lib/unittest/...
File tests/lib/unittest/unittest_test.dart (right):

https://chromiumcodereview.appspot.com/10692051/diff/2001/tests/lib/unittest/...
tests/lib/unittest/unittest_test.dart:154: m.getLogs(callsTo('foo', anything,
anything)).verify(happenedExactly(4));
nit: 80 col

[Siggi Cherem (dart-lang), 2012-06-29 23:50:50]

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.dart
File lib/unittest/mock.dart (right):

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:234: String pad2(int v) {
alternatively:
String _pad2(int value) => (value >= 10 ? '$value' : '0$value');

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:234: String pad2(int v) {
make this private

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:236: return s.substring(s.length-2);
nit: spaces around operator

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:244: Date when; // The time of the event.
we should make all of these // comments in to real dartdoc comments:
/** The time of the event. */
Date when;

/** The mock object's name, if any. */
String mockName;

/** Name of the method called on the mock. */
String methodName;

/** Arguments passed to the mocked call. */
String args;

...

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:299: logs = new List<LogEntry>();
blend of some of the suggestions John had in the other class:
LogEntryList([this.filter])
    : logs = <LogEntry>[];

(omit = null, use initializer section, use literal syntax for new List<X>();)

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:319: if (mockName != null && mockName != entry.mockName)
{
what does it mean to have a null mockName?

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:345: String s = '';
use string buffer instead?

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:666: Mock([this.name = null, this.throwIfNoBehavior =
false, this.log = null]) {
omit =null (x2)

https://chromiumcodereview.appspot.com/10692051/diff/7001/lib/unittest/mock.d...
lib/unittest/mock.dart:812: *     getLogs(callsTo(...)).verify(...);
add receiver in this example:
    mock.getLogs(...)

https://chromiumcodereview.appspot.com/10692051/diff/7001/tests/lib/unittest/...
File tests/lib/unittest/unittest_test.dart (right):

https://chromiumcodereview.appspot.com/10692051/diff/7001/tests/lib/unittest/...
tests/lib/unittest/unittest_test.dart:156: m.getLogs(callsTo('foo', anything,
anything)).verify(happenedExactly(4));
80 col

https://chromiumcodereview.appspot.com/10692051/diff/7001/tests/lib/unittest/...
tests/lib/unittest/unittest_test.dart:218: } else if (testName == 'mock test 7
(No behavior)') {
another reason to move mock + matchers into sub-libraries of unittest, we could
potentially test them outside of this complex unittest_test